Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully formed Github repo urls leading to 400 error #835

Open
fperez opened this issue Jun 12, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@fperez
Copy link
Member

commented Jun 12, 2019

When giving nbviewer a fully formed Github repo URL, say https://github.com/jupyter-widgets/tutorial, a 400 error results:

To Reproduce

  1. Go to https://nbviewer.jupyter.org.
  2. Paste into the input text box: https://github.com/jupyter-widgets/tutorial
  3. Nbviewer turns the above into https://nbviewer.jupyter.org/urls/github.com/jupyter-widgets/tutorial and produces a 400 : Bad Request error.

Expected behavior
The repo should be rendered. That works as expected if instead one types only the org/repo part: jupyter-widgets/tutorial, leading to the URL https://nbviewer.jupyter.org/github/jupyter-widgets/tutorial/tree/master/.

I'm pretty sure this used to work, but I don't know when the change occured. Oddly this seems like it should be an often reported problem, but I couldn't find a dupe.

@parente

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

#832 was reported recently and is somewhat related. It appears to work for full GitHub URLs that resolve to ipynb files but perhaps not to the org/repo path alone.

@fperez

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

It's possible this is a corner case that didn't work in the past (I may be wrong above) but if it doesn't then I think it should - the combo of what works/doesn't in terms of URLs or bare repo names is odd and surprising.

I tagged it as such for now, assuming I'm wrong and it's not a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.