Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
parse urls when validating redirect targets
simplifies check for redirects to external hosts
- Loading branch information
Showing
2 changed files
with
52 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| """Tests for login redirects""" | ||
|
|
||
| import requests | ||
| from tornado.httputil import url_concat | ||
|
|
||
| from notebook.tests.launchnotebook import NotebookTestBase | ||
|
|
||
|
|
||
| class LoginTest(NotebookTestBase): | ||
| def login(self, next): | ||
| first = requests.get(self.base_url() + "login") | ||
| first.raise_for_status() | ||
| resp = requests.post( | ||
| url_concat( | ||
| self.base_url() + "login", | ||
| {'next': next}, | ||
| ), | ||
| allow_redirects=False, | ||
| data={ | ||
| "password": self.token, | ||
| "_xsrf": first.cookies.get("_xsrf", ""), | ||
| }, | ||
| cookies=first.cookies, | ||
| ) | ||
| resp.raise_for_status() | ||
| return resp.headers['Location'] | ||
|
|
||
| def test_next_bad(self): | ||
| for bad_next in ( | ||
| "//some-host", | ||
| "//host" + self.url_prefix + "tree", | ||
| "https://google.com", | ||
| "/absolute/not/base_url", | ||
| ): | ||
| url = self.login(next=bad_next) | ||
| self.assertEqual(url, self.url_prefix) | ||
| assert url | ||
|
|
||
| def test_next_ok(self): | ||
| for next_path in ( | ||
| "tree/", | ||
| "//" + self.url_prefix + "tree", | ||
| "notebooks/notebook.ipynb", | ||
| "tree//something", | ||
| ): | ||
| expected = self.url_prefix + next_path | ||
| actual = self.login(next=expected) | ||
| self.assertEqual(actual, expected) |