Remove redundant sort from back-end #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm +1 I think we should wait post 5.0 though, just not to introduce a potential change so close to a release. |
Member
|
Thanks! |
takluyver
added a commit
to takluyver/notebook
that referenced
this pull request
May 13, 2017
PR jupytergh-2281 removed the sorting step from the server. This can result in non-deterministic test failures, because the test checked against a list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking for fixme's in the code I found the following. In the file notebook/services/contents/handlers.py a fixme comment mentions that the sorting of the contents of a directory should be done in the front-end. I checked the code on the front-end where this is supposed to be done.
I found out that it is already done there. So the sorting is done redundantly on the front-end and the back-end. I removed the sorting from the back-end.