Allow all MathJax output formats #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is the largest rather than white-listing HTML-CSS. This means the various other renderers (perhaps most importantly, MML) are available, not just HTML-CSS This increases the size of a notebook install by ~800k/19MB or 5%. Alternately, we could *only* add MML, which would have a negligible affect on install size.
trust that it will be re-run after npm/bower
|
5.0 of 4.2 ? +1 |
|
I'm not sure. I could go either way. |
|
@jasongrout you brought up some follow up that suggested maybe we should include SVG anyhow. Did you want to check in here? |
|
For reference: Adding SVG with a single font (like we do with HTML-CSS) would increase install size by 2.5 MB, or an additional ~13%. |
|
Is install size a real worry here? This doesn't seem so bad, I'm ready to merge this. |
|
I don't think an extra 2.5MB is a problem. IIRC, the full mathjax bundle was about 10x the size of our entire package, which seemed a bit much, but I think it's fine to selectively add bits back in if there's a use for them. |
we now ship all mathjax output formats We still strip down to a single font (STIX-Web)
|
Okay, this now includes all output formats, including SVG. SVG is scrubbed down to a single font, just like we do with HTML-CSS. |
Carreau
added a commit
that referenced
this pull request
Feb 23, 2016
Allow all MathJax output formats
minrk
added a commit
to minrk/notebook
that referenced
this pull request
Feb 24, 2016
rather than white-listing HTML-CSS and scrubbing all others. This means the various other renderers (perhaps most importantly, MML) are available, not just HTML-CSS. Fonts other than STIX-Web are still scrubbed, since much of the size is due to the many font choices. This increases the size of a notebook install by ~3.5k/19MB or 18%. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than white-listing HTML-CSS and scrubbing all others. This means the various other renderers (perhaps most importantly, MML) are available, not just HTML-CSS.
Fonts other than STIX-Web are still scrubbed, since much of the size is due to the many font choices.
This increases the size of a notebook install by ~3.5k/19MB or 18%.
A smaller change would be to only add MML, which would have a negligible affect on install size.
closes #1037