Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update table styles to be consistent with JupyterLab #1776
Looks great - two question?
-1 on backporting a big visual change to a minor release, even if the change is good.
It's also, I think, a recipe to get questions during tutorials like "I don't have the same thing how do I get that".
That's just a preference though.
+1 for the change otherwise,
I would also strongly recommend to read this piece of news
@Carreau Sorry, I didn't see your comment! I understand your point about holding off until a major release... According to our release policy, UI changes are reserved for major releases. However, I am comfortable releasing this with 4.3 as it changes a non-interactive UI (vs. something interactive, like the menu or toolbar). Given the Windows blog post, we should save the shiny new table for a rainy day
I think it's a nice feature to have whether the table is very wide or not.
My only concern about waiting for 5.0 is that release may take a while to get out. Two reasons: i) in the past we have planned on doing that at the same time as JupyterLab 1.0 and ii) there have been Ui changes in master that will require a lot of UI/UX/design review and testing.
But in general, I do think that pushing major design changes in point releases isn't great. Would love to get @fperez take on that.
In terms of a hover, I am open to it. But let's merge this PR without it and then play with different hover styles in JupyterLab to see what makes sense.
And that's exactly the reason I don't want to backport. There have been a number of things we said we wouldn't do (like make JupyterLab only an extension) exactly to push notebook 5.0 forward.
Backporting starts to become hard, and I'm in favor of saying that if you want things out, then some cycles of the developers of JupyterLab should be spent on making 5.0 a reality. I don't have much time to help @gnestor and I don't want to bother him more. PLus with 4.x growing and 5.0 on it's way + JupyterLab, the testing of each branch by developer is quasi-null. Which increase the risk of bugs.
Also, for example 4.x does not have the ability to order file by date in the dashboard which is well beyond time to release. So while I can't prevent you from backporting things to 4.x, I'm exceptionally going to start putting the strongest -1 on backporting to 4.x until 5.0 is out, starting with this.
Sep 28, 2016
referenced this pull request
Nov 23, 2016
I like the new table style, but is the
I have a notebook with an innocuous table in it:
field name | contents -----------|--------- left | impulse responses for the left ear right | impulse responses for the right ear fs | sampling rate apparent_azimuth | directions of sound incidence (in radians)
For comparison, this is how it is rendered right here on Github:
With the new table style, it looks like this:
I don't see a reason for limiting the column width in this case. Without the
I don't think my cell contents are exceedingly wide.
Should the width probably be limited in auto-generated tables (like
@mgeier the issue is that in the wild it is very common to have tables that have dozens or even hundreds of columns. When that shows up, not having the
However, you do make a really good point about tables in markdown. Those are handcrafted and would usually be smaller. I would be fine if we add some conditional CSS to remove the max-width on those. Can you submit a PR or at least open an issue targeted at the 5.0 milestone? Thanks!
Thanks, we will get this done!…
On Thu, Dec 22, 2016 at 9:16 AM, Matthias Geier ***@***.***> wrote: @ellisonbg <https://github.com/ellisonbg> Done: #2008 <#2008> I can't set a target milestone, I've just mentioned it in the text. Sorry I can't actually implement this, I have too much in my pipeline already. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1776 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr0NZHzwIYYSMZrnF3lMnTyHIsTR66ks5rKqJlgaJpZM4KCOj1> .
-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub firstname.lastname@example.org and email@example.com
The changes were all made to https://github.com/jupyter/notebook/blob/master/notebook/static/notebook/less/renderedhtml.less in #1776. To switch back to old styles, you can manually edit this file or if you're running from a clone of this repo, just revert the commit in #1776.
We are open to suggestions as to how to improve the table style