Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md #1781

Merged
merged 2 commits into from Sep 22, 2016

Conversation

3 participants
@himani1
Copy link
Contributor

commented Sep 22, 2016

Fixed minor mistakes in readme.

Updated README.md
Fixed minor mistakes in readme.
@takluyver

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Thanks for looking at this. You're right that the language there is a bit hard to read, but unfortunately I don't think your changes improve on what's currently there.

@himani1

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2016

@takluyver : I understand. There was a bit too much use of 'the' in that. I thought with the changes I have proposed, it'd be clearer to read.

@takluyver

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Some of the 'the'-s are necessary for the text to make sense, though, and others are there to match the way we tend to talk about them - e.g. we say "the IPython kernel" rather than using "IPython kernel" as a name. However, we do use "Project Jupyter" as a name, so it doesn't need a 'the'.

@himani1

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2016

@takluyver : Ok, I get it now. Thanks for correcting me.

@minrk minrk added this to the 5.0 milestone Sep 22, 2016

@minrk

minrk approved these changes Sep 22, 2016

Copy link
Member

left a comment

Thanks!

@takluyver takluyver merged commit 3ac3b25 into jupyter:master Sep 22, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@takluyver

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Thanks :-)

@gnestor gnestor added this to Merged PRs in 5.0 Feb 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.