New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change favicon when busy #1837

Merged
merged 2 commits into from Oct 18, 2016

Conversation

5 participants
@gnestor
Contributor

gnestor commented Oct 15, 2016

Closes #1820

I’m open to busy icon suggestions…

screenshot

@gnestor gnestor modified the milestones: 4.3, 5.0 Oct 15, 2016

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 17, 2016

Member

👍

Member

takluyver commented Oct 17, 2016

👍

@jasongrout

This comment has been minimized.

Show comment
Hide comment
@jasongrout

jasongrout Oct 17, 2016

Member

I really like this change. Can we also not change the page title anymore, now that we have this much less distracting indicator in a tab? This may be for a different PR, but if you could do it in this PR, that would be awesome.

Member

jasongrout commented Oct 17, 2016

I really like this change. Can we also not change the page title anymore, now that we have this much less distracting indicator in a tab? This may be for a different PR, but if you could do it in this PR, that would be awesome.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 17, 2016

Member

I'd also favour not changing the title - my tabs are often quite short, and "(Busy)" will take up ~all the visible space.

Member

takluyver commented Oct 17, 2016

I'd also favour not changing the title - my tabs are often quite short, and "(Busy)" will take up ~all the visible space.

@gnestor

This comment has been minimized.

Show comment
Hide comment
@gnestor

gnestor Oct 17, 2016

Contributor

@jasongrout @takluyver Updated this PR with your suggestion...

Contributor

gnestor commented Oct 17, 2016

@jasongrout @takluyver Updated this PR with your suggestion...

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Oct 17, 2016

Member

I kicked Appveyor.

Member

Carreau commented Oct 17, 2016

I kicked Appveyor.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 18, 2016

Member

Appveyor is having constant problems with Python 2 right now, failing with the error "The input line is too long." I don't know what to do about that - I'm ignoring it for now...

Member

takluyver commented Oct 18, 2016

Appveyor is having constant problems with Python 2 right now, failing with the error "The input line is too long." I don't know what to do about that - I'm ignoring it for now...

@takluyver takluyver merged commit cb88603 into jupyter:master Oct 18, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Oct 18, 2016

Member

Nice!

Member

minrk commented Oct 18, 2016

Nice!

@gnestor gnestor deleted the gnestor:busy-favicon branch Oct 18, 2016

@gnestor gnestor added this to Merged PRs in 5.0 Feb 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment