add jupyter notebook password entrypoint#2007
Merged
rgbkrk merged 4 commits intojupyter:masterfrom Jan 13, 2017
Merged
Conversation
records, hashes, and stores password in json config
takluyver
reviewed
Dec 22, 2016
notebook/auth/security.py
Outdated
| try: | ||
| os.chmod(config_file, mode) | ||
| except Exception: | ||
| print("Failed to set permissions on %s:" % config_file, file=sys.stderr) |
Member
There was a problem hiding this comment.
This needs from __future__ import print_function for Py2.
Member
There was a problem hiding this comment.
Is this only meant to be used at the command line? I'm wondering about the direct print to stderr vs using logging... Just curious.
Member
Author
There was a problem hiding this comment.
switched to a regular warning
Member
|
Minor question above, but otherwise looks good, thx! |
minrk
changed the title
jupyter notebook password entrypointjupyter notebook password entrypoint
Member
Author
|
docs and tests added |
Member
|
Great idea. I'd be comfortable with it being a top level command too, no strength behind that opinion though. |
Member
|
Anything else to do on this? It looks ready to me. |
Member
Author
|
I'm all set here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that we are securing notebooks by default, increasing the convenience of defining a password is more important.
Mostly copied from the
tools/secure_notebookscript. I omitted the ssl-cert-generation from that script, since I think it's less portable to platforms like Windows, and there are many more ways to do it.TODO:
cc @fperez
records, hashes, and stores password in json config