Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `jupyter notebook password` entrypoint #2007

Merged
merged 4 commits into from Jan 13, 2017
Merged

add `jupyter notebook password` entrypoint #2007

merged 4 commits into from Jan 13, 2017

Conversation

@minrk
Copy link
Member

@minrk minrk commented Dec 22, 2016

now that we are securing notebooks by default, increasing the convenience of defining a password is more important.

Mostly copied from the tools/secure_notebook script. I omitted the ssl-cert-generation from that script, since I think it's less portable to platforms like Windows, and there are many more ways to do it.

TODO:

  • update 'securing the notebook' docs with reference to this command
  • exercise with tests

cc @fperez

records, hashes, and stores password in json config

records, hashes, and stores password in json config
try:
os.chmod(config_file, mode)
except Exception:
print("Failed to set permissions on %s:" % config_file, file=sys.stderr)

This comment has been minimized.

@takluyver

takluyver Dec 22, 2016
Member

This needs from __future__ import print_function for Py2.

This comment has been minimized.

@fperez

fperez Dec 23, 2016
Member

Is this only meant to be used at the command line? I'm wondering about the direct print to stderr vs using logging... Just curious.

This comment has been minimized.

@minrk

minrk Jan 3, 2017
Author Member

switched to a regular warning

@fperez
Copy link
Member

@fperez fperez commented Dec 23, 2016

Minor question above, but otherwise looks good, thx!

@minrk minrk changed the title [WIP] add `jupyter notebook password` entrypoint add `jupyter notebook password` entrypoint Jan 3, 2017
@minrk
Copy link
Member Author

@minrk minrk commented Jan 3, 2017

docs and tests added

@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jan 3, 2017

Great idea. I'd be comfortable with it being a top level command too, no strength behind that opinion though.

@takluyver
Copy link
Member

@takluyver takluyver commented Jan 13, 2017

Anything else to do on this? It looks ready to me.

@minrk
Copy link
Member Author

@minrk minrk commented Jan 13, 2017

I'm all set here.

@rgbkrk rgbkrk merged commit f5f97d1 into jupyter:master Jan 13, 2017
4 checks passed
4 checks passed
codecov/patch 92.98% of diff hit (target 0.00%)
Details
codecov/project 74.48% (+0.21%) compared to 645f0f9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver takluyver added this to the 5.0 milestone Jan 31, 2017
@gnestor gnestor added this to Merged PRs in 5.0 Feb 4, 2017
@minrk minrk deleted the minrk:password branch Feb 8, 2017
@minrk minrk mentioned this pull request Feb 8, 2017
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.0
Merged PRs
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.