Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include metadata when copying a cell #2349

Merged
merged 1 commit into from Apr 10, 2017
Merged

include metadata when copying a cell #2349

merged 1 commit into from Apr 10, 2017

Conversation

@parmentelat
Copy link
Contributor

@parmentelat parmentelat commented Mar 29, 2017

Following up on #2273, I came up with this proposal.

I was not able to test this though, because I do not know how to try out my modified code in a running jupyter

Also I chose to copy the original cell's metadata using json, because I believe a copy is required in this context, but there might be better ways to do that copy

This is my first pull request ever and I am not too comfy in javascript either..

closes #2273

@gnestor gnestor added this to the 5.1 milestone Mar 29, 2017
I was not able to test this though
preserves initial strategy that uses original cell as cell B
so as to preserve selection
@minrk minrk changed the title an early attempt to fix #2273 include metadata when copying a cell Apr 10, 2017
@minrk
Copy link
Member

@minrk minrk commented Apr 10, 2017

Thanks, this should work!

@minrk minrk merged commit f5f2ead into jupyter:master Apr 10, 2017
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 0d28945...6aaa4d7
Details
codecov/project 77.24% (-0.04%) compared to 0d28945
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor gnestor mentioned this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.