Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Bidi support #2357
Hello @Carreau ,
This pull request contains the bidi work and fixes the UI mirroring issues.
Here are some functions added such : LoadLocale -> to load the required locale that is defined at Momentjs based on the browser preferences setting . I propose to leave it to the user selection rather than the browser preferences and to create a UI component to toggle among the list of locales.
For Numeric Shaping : I need another component to toggle between the options.
With respect to National Calendar , I found an external plugin at Momentjs called moment-hijri that is dedicated to Hijri-calendar so I removed the related functions that were mentioned at the design. Actually I didn't find moment at the documentation . I'll put the links below :
Could you please review ?
referenced this pull request
Apr 2, 2017
@gnestor ,Conflicts have been resolved.
The current status is having a mirrored UI with loading the dedicated Locale form momentJS.
Sep 15, 2017
@takluyver Should we add the following from https://github.com/jupyter/notebook/blob/master/notebook/i18n/README.md#how-the-language-is-selected- to the README?