New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check allow_root after calling super #2421

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
3 participants
@minrk
Member

minrk commented Apr 18, 2017

super can dispatch to subcommands such as list, etc.

we only want to check root at most for starting the notebook server itself.

closes #2375

check allow_root after calling super
super can dispatch to subcommands such as `list`, etc.

we only want to check root *at most* for starting the notebook server itself.

@takluyver takluyver closed this Apr 18, 2017

@takluyver takluyver reopened this Apr 18, 2017

@minrk minrk added this to the 5.1 milestone Apr 19, 2017

@takluyver takluyver merged commit 28d5454 into jupyter:master Apr 19, 2017

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +22.57% compared to 6cebd3e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor

This comment has been minimized.

Show comment
Hide comment
@gnestor

gnestor Jul 3, 2017

Contributor

@meeseeksdev backport to 4.x

Contributor

gnestor commented Jul 3, 2017

@meeseeksdev backport to 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment