Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keymaps that conflict with non-English keyboards #2535

Merged
merged 2 commits into from Jun 7, 2017

Conversation

@gnestor
Copy link
Contributor

@gnestor gnestor commented May 30, 2017

Fixes #2379

@gnestor gnestor added the bug label May 30, 2017
@gnestor gnestor added this to the 5.1 milestone May 30, 2017
@gnestor
Copy link
Contributor Author

@gnestor gnestor commented May 31, 2017

@minrk Care to review? This reverts some of #963 which caused conflicts on non-English keyboards.

@minrk
Copy link
Member

@minrk minrk commented Jun 1, 2017

Is it just the ctrl-alt shortcuts or also the cmd-alt shortcuts that cause this problem? I would certainly be sad to lose those.

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Jun 2, 2017

@minrk This is only removing the Cmd-Alt-[ shortcut, not all Cmd-Alt-*

@minrk
Copy link
Member

@minrk minrk commented Jun 2, 2017

Sorry. My question was whether it was ctrl-alt-[ or cmd-alt-[ or both that cause the issue.

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Jun 2, 2017

I inquired about that in the issue. Let's see what people say 👍 I think we just need to avoid using shortcuts that involve [ and ], but I saw a one comment about \ and @Carreau suggested that we also disable ones involving /.

@Carreau
Copy link
Member

@Carreau Carreau commented Jun 2, 2017

I believe that's anything that touch [,], and alt. Alt is heavily use on french keyboard to type punctuation. You just can't bind by default to anything that uses alt.
That one of the main reason why I'm not an emacs user as most alt-based shortcut were conflicting with typing.

The MacOS keyboard is slightly different, but same battle. Alt is a critical key.

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Jun 7, 2017

Ok, so this PR just comments out the 2 commands that involve alt so I think we can merge this and iterate if necessary.

@Carreau Carreau merged commit 4b8cc28 into jupyter:master Jun 7, 2017
4 checks passed
@Carreau
Copy link
Member

@Carreau Carreau commented Jun 7, 2017

Ok, so this PR just comments out the 2 commands that involve alt so I think we can merge this and iterate if necessary.

Yep, good point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants