Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes single ` markdown highlighting #2571

Merged

Conversation

@vidriduch
Copy link
Contributor

@vidriduch vidriduch commented Jun 12, 2017

Changes highlighting of text surrounded by single ` in markdown cells by
adding gray background under the text. Highlighting should resemble the
stack-overflow highlighting.

Before:
before

After:
after

Signed-off-by: Ondrej o.jariabka@gmail.com

Changes highlighting of text surrounded by single ` in markdown cells by
adding gray background under the text. Highlighting should resemble the
stack-overflow highlighting.

Signed-off-by: Ondrej <o.jariabka@gmail.com>
@vidriduch
Copy link
Contributor Author

@vidriduch vidriduch commented Jun 12, 2017

Should close issue #2561

@takluyver takluyver added this to the 5.1 milestone Jun 12, 2017
@takluyver
Copy link
Member

@takluyver takluyver commented Jun 12, 2017

LGTM. I'll give other people a while to look at it. Ping me in a couple of days if there are no more comments.

Added padding of 1px from top and bottom and 5px from left and right
around gray box of single ` markdown.

Signed-off-by: Ondrej <o.jariabka@gmail.com>
@minrk minrk merged commit 2eed68e into jupyter:master Jun 14, 2017
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 3140085...533aea1
Details
codecov/project 78.13% remains the same compared to 3140085
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor gnestor mentioned this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.