Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose URL with auth token in notebook UI #2666

Merged
merged 2 commits into from Jul 20, 2017
Merged

Expose URL with auth token in notebook UI #2666

merged 2 commits into from Jul 20, 2017

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Jul 19, 2017

This provides a crude way to copy the link from one browser (right click the Jupyter logo) to get authenticated in another browser.

Closes gh-2094

This provides a crude way to copy the link from one browser (right click
the Jupyter logo) to get authenticated in another browser.

Closes gh-2094
@takluyver takluyver added this to the 5.1 milestone Jul 19, 2017
@@ -118,7 +118,7 @@

<div id="header">
<div id="header-container" class="container">
<div id="ipython_notebook" class="nav navbar-brand pull-left"><a href="{{default_url}}" title='{% trans %}dashboard{% endtrans %}'>{% block logo %}<img src='{{static_url("base/images/logo.png") }}' alt='Jupyter Notebook'/>{% endblock %}</a></div>
<div id="ipython_notebook" class="nav navbar-brand pull-left"><a href="{{default_url}}?token={{token}}" title='{% trans %}dashboard{% endtrans %}'>{% block logo %}<img src='{{static_url("base/images/logo.png") }}' alt='Jupyter Notebook'/>{% endblock %}</a></div>

This comment has been minimized.

@minrk

minrk Jul 20, 2017
Member

This exposes the login token on the login page, so unauthenticated users can just click this link to login. We should make sure to only include this if the page being served is already authenticated, and only when the token is defined.

This comment has been minimized.

@takluyver

takluyver Jul 20, 2017
Author Member

Good job one of us is thinking about this! ;-)

@takluyver
Copy link
Member Author

@takluyver takluyver commented Jul 20, 2017

Should be fixed now. I'm using the same conditions (logged_in and token) as we already use for putting data-jupyter-api-token in the body tag.

@minrk minrk merged commit c4a5dc0 into jupyter:master Jul 20, 2017
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 5192d72...208e7c7
Details
codecov/project 80.07% (+0.29%) compared to 5192d72
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor gnestor mentioned this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.