New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden prompt overlay button #2681

Merged
merged 1 commit into from Jul 30, 2017

Conversation

Projects
None yet
4 participants
@gnestor
Contributor

gnestor commented Jul 24, 2017

Closes #2590

It looks like this.collapsed is returning false and therefore this.prompt_overlay.show() is not being called: https://github.com/jupyter/notebook/blob/master/notebook/static/notebook/js/outputarea.js#L155

@gnestor

This comment has been minimized.

Show comment
Hide comment
@gnestor

gnestor Jul 24, 2017

Contributor

@minrk Mind taking a look at this? Just wanna make sure that this doesn't behave unexpectedly in some edge case.

Contributor

gnestor commented Jul 24, 2017

@minrk Mind taking a look at this? Just wanna make sure that this doesn't behave unexpectedly in some edge case.

@gnestor gnestor added this to the 5.1 milestone Jul 24, 2017

@gnestor gnestor requested review from minrk and takluyver Jul 27, 2017

@gnestor gnestor referenced this pull request Jul 30, 2017

Closed

Release 5.1 #2708

11 of 11 tasks complete
@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Jul 30, 2017

Member

Let's try it to see if it has side effects.

Member

Carreau commented Jul 30, 2017

Let's try it to see if it has side effects.

@Carreau Carreau merged commit decb30d into jupyter:master Jul 30, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 67b0723...572cc37
Details
codecov/project 79.76% remains the same compared to 67b0723
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor deleted the gnestor:fix-prompt-overlay branch Jul 31, 2017

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Aug 2, 2017

Member

I think this is right. I saw this when I did my PR, but then forgot to investigate.

Member

minrk commented Aug 2, 2017

I think this is right. I saw this when I did my PR, but then forgot to investigate.

@gnestor gnestor referenced this pull request Aug 3, 2017

Merged

Add 5.1.0 to changelog #2723

@jasongrout

This comment has been minimized.

Show comment
Hide comment
@jasongrout

jasongrout Oct 20, 2017

Member

FYI, this breaks the prompt_area: false argument to the output area constructor. We're seeing this in ipywidgets, where we explicitly set that to false, but now the prompt area is still shown.

For now, we'll just hardcode some css to hide the prompt area in output widgets. I think it would be enough to check this.prompt_area and if it is false, explicitly hide the prompt area as before.

CC jupyter-widgets/ipywidgets#1765

Member

jasongrout commented Oct 20, 2017

FYI, this breaks the prompt_area: false argument to the output area constructor. We're seeing this in ipywidgets, where we explicitly set that to false, but now the prompt area is still shown.

For now, we'll just hardcode some css to hide the prompt area in output widgets. I think it would be enough to check this.prompt_area and if it is false, explicitly hide the prompt area as before.

CC jupyter-widgets/ipywidgets#1765

@jasongrout

This comment has been minimized.

Show comment
Hide comment
@jasongrout

jasongrout Oct 20, 2017

Member

Proposed fix: #2961

Member

jasongrout commented Oct 20, 2017

Proposed fix: #2961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment