Restore flat edge of rendered html code block#2691
Merged
gnestor merged 2 commits intojupyter:masterfrom Jul 27, 2017
Merged
Conversation
The extra padding causes the first line of each markdown rendered code block to be indented, but does not indent the rest of the code block, resulting in a jagged left edge. Removing this bit of CSS restores a flat left edge.
You can verify this by trying to render the following:
abc
def
ghi
Contributor
|
Thanks for your contribution @invisibleroads! Can you please check that "Allow edits from maintainers" box in the right column or add this CSS rule to renderedhtml.less? This will preserve the padding for inline code elements (and not code block elements). |
Contributor
Author
|
Now I understand that you were trying to add padding to inline code in rendered markdown. |
Contributor
|
Thanks! Will merge as soon as CI build passes 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra padding causes the first line of each markdown rendered code block to be indented, but does not indent the rest of the code block, resulting in a jagged left edge. Removing this bit of CSS restores a flat left edge.
You can verify this by trying to render the following:
This fix will revert 533aea1.