New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore flat edge of rendered html code block #2691

Merged
merged 2 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@invisibleroads
Contributor

invisibleroads commented Jul 26, 2017

The extra padding causes the first line of each markdown rendered code block to be indented, but does not indent the rest of the code block, resulting in a jagged left edge. Removing this bit of CSS restores a flat left edge.

You can verify this by trying to render the following:

abc
    def
    ghi

This fix will revert 533aea1.

screenshot from 2017-07-26 15-39-22

Revert 533aea1
The extra padding causes the first line of each markdown rendered code block to be indented, but does not indent the rest of the code block, resulting in a jagged left edge. Removing this bit of CSS restores a flat left edge.

You can verify this by trying to render the following:

    abc
        def
        ghi

@invisibleroads invisibleroads changed the title from Revert 533aea11fdcb3a358add0ae4cbe41c97dac2cf2c to Restore flat edge of rendered html code block Jul 26, 2017

@gnestor

This comment has been minimized.

Show comment
Hide comment
@gnestor

gnestor Jul 27, 2017

Contributor

Thanks for your contribution @invisibleroads! Can you please check that "Allow edits from maintainers" box in the right column or add this CSS rule to renderedhtml.less?

p code {
    padding: 1px 5px;
}

This will preserve the padding for inline code elements (and not code block elements).

Contributor

gnestor commented Jul 27, 2017

Thanks for your contribution @invisibleroads! Can you please check that "Allow edits from maintainers" box in the right column or add this CSS rule to renderedhtml.less?

p code {
    padding: 1px 5px;
}

This will preserve the padding for inline code elements (and not code block elements).

@gnestor gnestor added this to the 5.1 milestone Jul 27, 2017

@invisibleroads

This comment has been minimized.

Show comment
Hide comment
@invisibleroads

invisibleroads Jul 27, 2017

Contributor

Now I understand that you were trying to add padding to inline code in rendered markdown.

Contributor

invisibleroads commented Jul 27, 2017

Now I understand that you were trying to add padding to inline code in rendered markdown.

@gnestor

This comment has been minimized.

Show comment
Hide comment
@gnestor

gnestor Jul 27, 2017

Contributor

Thanks! Will merge as soon as CI build passes 👍

Contributor

gnestor commented Jul 27, 2017

Thanks! Will merge as soon as CI build passes 👍

@gnestor gnestor merged commit bbd2ac6 into jupyter:master Jul 27, 2017

4 checks passed

codecov/patch Coverage not affected when comparing a916035...644a8aa
Details
codecov/project 79.76% remains the same compared to a916035
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor referenced this pull request Aug 3, 2017

Merged

Add 5.1.0 to changelog #2723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment