Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore flat edge of rendered html code block #2691

Merged
merged 2 commits into from Jul 27, 2017

Conversation

@invisibleroads
Copy link
Contributor

@invisibleroads invisibleroads commented Jul 26, 2017

The extra padding causes the first line of each markdown rendered code block to be indented, but does not indent the rest of the code block, resulting in a jagged left edge. Removing this bit of CSS restores a flat left edge.

You can verify this by trying to render the following:

abc
    def
    ghi

This fix will revert 533aea1.

screenshot from 2017-07-26 15-39-22

The extra padding causes the first line of each markdown rendered code block to be indented, but does not indent the rest of the code block, resulting in a jagged left edge. Removing this bit of CSS restores a flat left edge.

You can verify this by trying to render the following:

    abc
        def
        ghi
@invisibleroads invisibleroads changed the title Revert 533aea11fdcb3a358add0ae4cbe41c97dac2cf2c Restore flat edge of rendered html code block Jul 26, 2017
@gnestor
Copy link
Contributor

@gnestor gnestor commented Jul 27, 2017

Thanks for your contribution @invisibleroads! Can you please check that "Allow edits from maintainers" box in the right column or add this CSS rule to renderedhtml.less?

p code {
    padding: 1px 5px;
}

This will preserve the padding for inline code elements (and not code block elements).

@gnestor gnestor added this to the 5.1 milestone Jul 27, 2017
@invisibleroads
Copy link
Contributor Author

@invisibleroads invisibleroads commented Jul 27, 2017

Now I understand that you were trying to add padding to inline code in rendered markdown.

@gnestor
Copy link
Contributor

@gnestor gnestor commented Jul 27, 2017

Thanks! Will merge as soon as CI build passes 👍

@gnestor gnestor merged commit bbd2ac6 into jupyter:master Jul 27, 2017
4 checks passed
@gnestor gnestor mentioned this pull request Aug 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants