Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow notebooks to be trusted without triggering a save #2718
Trust should now add the notebook's signature without needing to trigger a save. Save will still trust the notebook, after checking and if it has not already been trusted.
I have not added an automatic refresh after trust, let me know if you think this would be a good idea.
I think this is a bug even on master. I noticed that without the check, the same signature was re-inserted each time the notebook was trusted.
@minrk, I probably shouldn't check this here - the issue should be fixed in nbformat. So, I'll revert that change, squash my commits and then we're good to go?