Make "extraKeys" consistent for notebook and editor#2745
Make "extraKeys" consistent for notebook and editor#2745takluyver merged 4 commits intojupyter:masterfrom
Conversation
|
I have no objections to changing the keymap, though that would be inconsistent with the notebook that default to "default" command amp. Would it be better to be consistent and change notebook as well ? I also would try to get a wider input on if we should change as it may break user habits. |
It seems like sublime is the default for the notebook (e.g. if I CMD + / it will comment out a block). |
Well no, the default is "default", the Ctrl-/ shortcut is set here |
|
Ahhh! Ok, we don't need to make sublime the default, I just need to make the notebook and editor |
gnestor
changed the title
notebook/static/edit/js/editor.js
Outdated
| "Tab": "indentMore", | ||
| "Shift-Tab" : "indentLess", | ||
| // "Cmd-Alt-[" : "indentAuto", | ||
| // "Ctrl-Alt-[" : "indentAuto", |
There was a problem hiding this comment.
Should these be in or out? If we don't want them, let's remove them completely rather than commenting them.
There was a problem hiding this comment.
Looks like you've removed them from cell.js, but not here ;-)
gnestor
force-pushed
the
keymap-default
branch
from
a4fe1af to
f222978
Compare
|
Reopening to rerun tests with master |
3 participants
Closes #2740