Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "extraKeys" consistent for notebook and editor #2745

Merged
merged 4 commits into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@gnestor
Copy link
Contributor

gnestor commented Aug 10, 2017

Closes #2740

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Aug 10, 2017

I have no objections to changing the keymap, though that would be inconsistent with the notebook that default to "default" command amp. Would it be better to be consistent and change notebook as well ?

I also would try to get a wider input on if we should change as it may break user habits.

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Aug 10, 2017

Would it be better to be consistent and change notebook as well ?

It seems like sublime is the default for the notebook (e.g. if I CMD + / it will comment out a block).

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Aug 11, 2017

It seems like sublime is the default for the notebook (e.g. if I CMD + / it will comment out a block).

Well no, the default is "default", the Ctrl-/ shortcut is set here

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Aug 11, 2017

Ahhh! Ok, we don't need to make sublime the default, I just need to make the notebook and editor extraKeys consistent 👌

@gnestor gnestor changed the title Set "sublime" to default keymap for editor Make "extraKeys" consistent for notebook and editor Aug 11, 2017

"Tab": "indentMore",
"Shift-Tab" : "indentLess",
// "Cmd-Alt-[" : "indentAuto",
// "Ctrl-Alt-[" : "indentAuto",

This comment has been minimized.

@takluyver

takluyver Sep 15, 2017

Member

Should these be in or out? If we don't want them, let's remove them completely rather than commenting them.

This comment has been minimized.

@gnestor

gnestor Sep 16, 2017

Author Contributor

I'll remove...

This comment has been minimized.

@takluyver

takluyver Sep 16, 2017

Member

Looks like you've removed them from cell.js, but not here ;-)

@gnestor gnestor force-pushed the gnestor:keymap-default branch from a4fe1af to f222978 Sep 16, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Sep 20, 2017

Reopening to rerun tests with master

@takluyver takluyver closed this Sep 20, 2017

@takluyver takluyver reopened this Sep 20, 2017

@takluyver takluyver merged commit 11ba6be into jupyter:master Sep 20, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 9dabaa2...f222978
Details
codecov/project 79.37% remains the same compared to 9dabaa2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor deleted the gnestor:keymap-default branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.