Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use RFC5987 encoding for filenames #2767

Merged
merged 2 commits into from Sep 15, 2017
Merged

use RFC5987 encoding for filenames #2767

merged 2 commits into from Sep 15, 2017

Conversation

@minrk
Copy link
Member

@minrk minrk commented Aug 16, 2017

as described in RFC 6266 describing Content-Disposition

This should result in the correct download filename for filenames with spaces and non-latin characters

finishes up #2761
closes #2742

@minrk
Copy link
Member Author

@minrk minrk commented Aug 16, 2017

Hold the phone, this doesn't work on Firefox, which apparently doesn't implement RFC 5987 the same as other browsers

works on FF

Loading

as described in RFC 6266 describing Content-Disposition
@takluyver
Copy link
Member

@takluyver takluyver commented Aug 16, 2017

On #2761 you said you've tested this on Firefox. Does that supersede your comment here that it doesn't work?

Loading

@minrk
Copy link
Member Author

@minrk minrk commented Aug 17, 2017

@takluyver yes, sorry. Commenting in two issues. My first attempt didn't work on Firefox, but it does now.

Loading

@takluyver takluyver added this to the 5.1 milestone Aug 17, 2017
@takluyver
Copy link
Member

@takluyver takluyver commented Aug 17, 2017

Thanks. Confirmed with a manual test.

I'd be in favour of putting this in 5.1, but if we're not confident enough it's fine to bump it to 5.2.

Loading

@minrk
Copy link
Member Author

@minrk minrk commented Aug 18, 2017

It worked for me, but the tiniest typo while I was figuring this out caused pretty weird failures that different browsers handled differently, so I'd be okay merging right after 5.1.

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Aug 18, 2017

I tested and I'm still seeing filenames with pluses vs. spaces?

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Aug 19, 2017

Ok, nevermind. I guess that I was not using a develop version of notebook or something. Looks good to me!

@minrk What do you think about merging this with 5.1 now? Feel free to mark as 5.2 otherwise.

Loading

@minrk minrk added this to the 5.2 milestone Aug 20, 2017
@minrk minrk removed this from the 5.1 milestone Aug 20, 2017
@minrk
Copy link
Member Author

@minrk minrk commented Aug 20, 2017

Let's be conservative and call it 5.2

Loading

@takluyver takluyver merged commit 5a0ee98 into jupyter:master Sep 15, 2017
4 checks passed
Loading
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants