Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use RFC5987 encoding for filenames #2767

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@minrk
Copy link
Member

minrk commented Aug 16, 2017

as described in RFC 6266 describing Content-Disposition

This should result in the correct download filename for filenames with spaces and non-latin characters

finishes up #2761
closes #2742

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Aug 16, 2017

Hold the phone, this doesn't work on Firefox, which apparently doesn't implement RFC 5987 the same as other browsers

works on FF

@minrk minrk force-pushed the minrk:filename branch from 3633065 to 0aa784d Aug 16, 2017

use RFC5987 encoding for filenames
as described in RFC 6266 describing Content-Disposition

@minrk minrk force-pushed the minrk:filename branch from 0aa784d to d6a534e Aug 16, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Aug 16, 2017

On #2761 you said you've tested this on Firefox. Does that supersede your comment here that it doesn't work?

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Aug 17, 2017

@takluyver yes, sorry. Commenting in two issues. My first attempt didn't work on Firefox, but it does now.

@takluyver takluyver added this to the 5.1 milestone Aug 17, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Aug 17, 2017

Thanks. Confirmed with a manual test.

I'd be in favour of putting this in 5.1, but if we're not confident enough it's fine to bump it to 5.2.

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Aug 18, 2017

It worked for me, but the tiniest typo while I was figuring this out caused pretty weird failures that different browsers handled differently, so I'd be okay merging right after 5.1.

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Aug 18, 2017

I tested and I'm still seeing filenames with pluses vs. spaces?

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Aug 19, 2017

Ok, nevermind. I guess that I was not using a develop version of notebook or something. Looks good to me!

@minrk What do you think about merging this with 5.1 now? Feel free to mark as 5.2 otherwise.

@minrk minrk modified the milestones: 5.2, 5.1 Aug 20, 2017

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Aug 20, 2017

Let's be conservative and call it 5.2

@takluyver takluyver merged commit 5a0ee98 into jupyter:master Sep 15, 2017

4 checks passed

codecov/patch 70% of diff hit (target 0%)
Details
codecov/project 79.37% (+<.01%) compared to f8d4d6a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.