Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed all python variables named file to file_name to not override built_in file #2830

Merged
merged 1 commit into from Sep 6, 2017

Conversation

@mpacer
Copy link
Member

@mpacer mpacer commented Sep 6, 2017

I do not believe that this is the cause of #2829, but in looking into it, I noticed that we were overwriting the file built_in which is only safe to do in python3. Since notebook is py2/3 compat, we shouldn't do that.

This takes care of all the cases I could find.

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

Loading

@blink1073 blink1073 merged commit 834b75a into jupyter:master Sep 6, 2017
4 checks passed
Loading
@takluyver takluyver added this to the 5.1 milestone Sep 11, 2017
@gnestor gnestor removed this from the 5.1 milestone Oct 13, 2017
@gnestor gnestor added this to the 5.2 milestone Oct 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants