Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid base64-literals in image tests #2851

Merged
merged 1 commit into from Sep 19, 2017

Conversation

Projects
None yet
3 participants
@minrk
Copy link
Member

minrk commented Sep 19, 2017

since they don't work in IPython anymore.

use Python variables storing raw bytes after decoding base64 from the tests

avoid base64-literals in image tests
use Python variables storing raw bytes

@minrk minrk referenced this pull request Sep 19, 2017

Merged

Upgrade xterm.js to 2.9.2 #2849

@rgbkrk rgbkrk merged commit 2d582e0 into jupyter:master Sep 19, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 9dabaa2...ed139a1
Details
codecov/project 79.37% remains the same compared to 9dabaa2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk deleted the minrk:fix-image-tests branch Sep 25, 2017

@gnestor gnestor added this to the 5.2 milestone Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.