Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codemirror.less to match CodeMirror's expected padding layout #2880

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Projects
None yet
4 participants
@jcb91
Copy link
Contributor

jcb91 commented Sep 30, 2017

fixes #2869 (I hope!)
see codemirror/CodeMirror#4042 (comment) for CodeMirror author's statement on how padding is expected to be arranged for proper layout of rulers (and possibly other stuff as well?!)

@rgbkrk

rgbkrk approved these changes Sep 30, 2017

@rgbkrk rgbkrk merged commit 099f83e into jupyter:master Sep 30, 2017

4 checks passed

codecov/patch Coverage not affected when comparing b884ff9...df19a51
Details
codecov/project 79.24% remains the same compared to b884ff9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver added this to the 5.2 milestone Oct 3, 2017

@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.