Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give Page constructor default arguments #2887

Merged
merged 1 commit into from Oct 1, 2017

Conversation

Projects
None yet
4 participants
@jcb91
Copy link
Contributor

jcb91 commented Oct 1, 2017

Otherwise, any extension using a template which relied on the old no-parameter formation breaks since #2279

give Page constructor default arguments
for any extension template which relied on the old no-parameter formation
@rgbkrk

rgbkrk approved these changes Oct 1, 2017

@rgbkrk rgbkrk merged commit 82c3357 into jupyter:master Oct 1, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 1cdb411...9552fc1
Details
codecov/project 79.24% remains the same compared to 1cdb411
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Oct 1, 2017

Thanks @jcb91

@takluyver takluyver added this to the 5.2 milestone Oct 3, 2017

@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.