Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The root directory of the notebook server should never be hidden #2907

Merged
merged 2 commits into from Oct 6, 2017

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Oct 6, 2017

Closes gh-2382

@takluyver takluyver added this to the 5.2 milestone Oct 6, 2017
gnestor
gnestor approved these changes Oct 6, 2017
@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Oct 6, 2017

TYVM @takluyver :-)

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 6, 2017

Tests are passing, shall I merge @takluyver?

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented Oct 6, 2017

I think it's OK. I saw you talking about releasing 5.2, so I thought I'd try to get this in.

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 6, 2017

Yes, after reading the whole discussion at #2382, I'm very grateful for this 🙏

Loading

@gnestor gnestor merged commit 12592ef into jupyter:master Oct 6, 2017
4 checks passed
Loading
@takluyver takluyver deleted the i2382 branch Oct 6, 2017
@gnestor gnestor removed this from the 5.2 milestone Oct 13, 2017
@gnestor gnestor added this to the 5.2 milestone Oct 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants