Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The root directory of the notebook server should never be hidden #2907

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@takluyver
Copy link
Member

takluyver commented Oct 6, 2017

Closes gh-2382

@takluyver takluyver added this to the 5.2 milestone Oct 6, 2017

@gnestor

gnestor approved these changes Oct 6, 2017

@choldgraf

This comment has been minimized.

Copy link
Contributor

choldgraf commented Oct 6, 2017

TYVM @takluyver :-)

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Oct 6, 2017

Tests are passing, shall I merge @takluyver?

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Oct 6, 2017

I think it's OK. I saw you talking about releasing 5.2, so I thought I'd try to get this in.

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Oct 6, 2017

Yes, after reading the whole discussion at #2382, I'm very grateful for this 🙏

@gnestor gnestor merged commit 12592ef into jupyter:master Oct 6, 2017

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.15% but relative coverage increased by +20.75% compared to 9b4660f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i2382 branch Oct 6, 2017

@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.