Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viewable_extensions #2913

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@gnestor
Copy link
Contributor

gnestor commented Oct 10, 2017

After more testing, .txt files should be opened using the /edit path and PDFs should be opened using the /files path. Additionally, archives and Microsoft Office files shouldn’t be considered “viewable.”

@gnestor gnestor added this to the 5.2 milestone Oct 10, 2017

@gnestor gnestor requested a review from rgbkrk Oct 10, 2017

@rgbkrk rgbkrk merged commit 2ee51ab into jupyter:master Oct 10, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 5841666...b82ca09
Details
codecov/project 79.07% remains the same compared to 5841666
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgbkrk rgbkrk deleted the gnestor:issue-2203-patch branch Oct 10, 2017

@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.