allow token-authenticated requests cross-origin by default#2920
Merged
takluyver merged 2 commits intojupyter:masterfrom Oct 20, 2017
Merged
allow token-authenticated requests cross-origin by default#2920takluyver merged 2 commits intojupyter:masterfrom
takluyver merged 2 commits intojupyter:masterfrom
Conversation
minrk
force-pushed
the
allow-origin-token
branch
from
12fcd69 to
014316c
Compare
blink1073
approved these changes
Oct 10, 2017
we already apply this logic in our server-side checks, but browsers check `Access-Control-Allow-Origin` headers themselves as well, meaning that token-authenticated requests can’t be made cross-origin without CORS headers from browsers, only scripts. This makes default browser and server-side origin checks consistent
minrk
force-pushed
the
allow-origin-token
branch
from
014316c to
9acf6a8
Compare
Member
Author
|
My conflict-avoidance strategy was not successful, apparently. Rebased. |
blink1073
approved these changes
Oct 11, 2017
Member
|
I'm never entirely sure about these CORS issues, but I think I understand the basic idea, and I'm happy to trust the two of you. Do you want anyone else to review it? Do you want it in for 5.2? |
Contributor
|
We're going to try to release 5.2.1. Should this be included? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we already apply this logic in our server-side checks, but browsers check
Access-Control-Allow-Originheaders themselves as well, meaning that token-authenticated requests can’t be made cross-origin without CORS headers from browsers, only scripts.This makes default browser and server-side origin checks consistent
includes #2919 to avoid merge conflicts