Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting token via JUPYTER_TOKEN env #2921

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@minrk
Copy link
Member

minrk commented Oct 10, 2017

more convenient for certain deployments than CLI arguments

allow setting token via JUPYTER_TOKEN env
more convenient for certain deployments than CLI arguments
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Oct 10, 2017

If it's set in both the config file and the environment, the config file will win, right? It's probably not a big problem, but I'd generally expect the environment variable to have precedence.

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Oct 11, 2017

Yes. There's a huge discussion about supporting env values better over on traitlets, but this is what's available to us for now, without doing some extra shenanigans.

@takluyver takluyver added this to the 5.2 milestone Oct 11, 2017

@takluyver takluyver closed this Oct 11, 2017

@takluyver takluyver reopened this Oct 11, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Oct 11, 2017

Wrong button

@takluyver takluyver merged commit 4a3fa4a into jupyter:master Oct 11, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
codecov/patch 33.33% of diff hit (target 0%)
Details
codecov/project 79.05% (-0.02%) compared to 2ee51ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk deleted the minrk:token-env branch Oct 11, 2017

@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.