Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting token via JUPYTER_TOKEN env #2921

Merged
merged 1 commit into from Oct 11, 2017
Merged

Conversation

@minrk
Copy link
Member

@minrk minrk commented Oct 10, 2017

more convenient for certain deployments than CLI arguments

more convenient for certain deployments than CLI arguments
@takluyver
Copy link
Member

@takluyver takluyver commented Oct 10, 2017

If it's set in both the config file and the environment, the config file will win, right? It's probably not a big problem, but I'd generally expect the environment variable to have precedence.

Loading

@minrk
Copy link
Member Author

@minrk minrk commented Oct 11, 2017

Yes. There's a huge discussion about supporting env values better over on traitlets, but this is what's available to us for now, without doing some extra shenanigans.

Loading

@takluyver takluyver added this to the 5.2 milestone Oct 11, 2017
@takluyver takluyver closed this Oct 11, 2017
@takluyver takluyver reopened this Oct 11, 2017
@takluyver
Copy link
Member

@takluyver takluyver commented Oct 11, 2017

Wrong button

Loading

@takluyver takluyver merged commit 4a3fa4a into jupyter:master Oct 11, 2017
3 of 4 checks passed
Loading
@minrk minrk deleted the token-env branch Oct 11, 2017
@gnestor gnestor removed this from the 5.2 milestone Oct 13, 2017
@gnestor gnestor added this to the 5.2 milestone Oct 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants