Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set cookie on base_url #2959

Merged
merged 1 commit into from Oct 20, 2017
Merged

set cookie on base_url #2959

merged 1 commit into from Oct 20, 2017

Conversation

@minrk
Copy link
Member

@minrk minrk commented Oct 19, 2017

avoids clobbering cookies when multiple notebook servers are run on one host (e.g. binder)

Users can override cookie_options.path = '/' if they want cookies to be shared across notebooks on one host.

avoids clobbering cookies when multiple notebook servers are run on one host.

Users can override `cookie_options.path = ‘/‘` if they *want* cookies to be shared across notebooks on one host.
@takluyver takluyver added this to the 5.3 milestone Oct 20, 2017
@takluyver takluyver merged commit 95a52f2 into jupyter:master Oct 20, 2017
4 checks passed
Loading
@gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 26, 2017

We're going to try to release 5.2.1. Should this be included?

Loading

@minrk minrk deleted the cookie-path branch Nov 15, 2017
@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Nov 17, 2017

@gnestor I guess this is too late to respond, but this is causing problems on mybinder. It would be great if there's a release made with this :)

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 17, 2017

We could do a 5.2.2 and only add this. Sound good?

Loading

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Nov 17, 2017

@gnestor that would be awesome!

Loading

@minrk
Copy link
Member Author

@minrk minrk commented Nov 21, 2017

Sorry I didn't respond promptly the first time around; not keeping up with my GitHub notifications. It would be handy for binder to have this in a patch release.

Loading

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Nov 28, 2017

Post-thanksgiving, any luck? :)

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 28, 2017

@yuvipanda So sorry to put this off. Will release 5.2.2 today 👌

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 28, 2017

@meeseeksdev backport to 5.2.2

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 28, 2017

Update: notebook 5.2.2 is published to pypi (https://pypi.org/project/notebook/5.2.2/) and PR is submitted for conda-forge (conda-forge/notebook-feedstock#25). Please confirm that this fixes the issue on binder and afterwards I will announce the new version on the mail list.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants