Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set cookie on base_url #2959

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
4 participants
@minrk
Copy link
Member

minrk commented Oct 19, 2017

avoids clobbering cookies when multiple notebook servers are run on one host (e.g. binder)

Users can override cookie_options.path = '/' if they want cookies to be shared across notebooks on one host.

set cookie on base_url
avoids clobbering cookies when multiple notebook servers are run on one host.

Users can override `cookie_options.path = ‘/‘` if they *want* cookies to be shared across notebooks on one host.

@takluyver takluyver added this to the 5.3 milestone Oct 20, 2017

@takluyver takluyver merged commit 95a52f2 into jupyter:master Oct 20, 2017

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 79.12% (+0.01%) compared to f763c03
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Oct 26, 2017

We're going to try to release 5.2.1. Should this be included?

@minrk minrk deleted the minrk:cookie-path branch Nov 15, 2017

@yuvipanda

This comment has been minimized.

Copy link
Contributor

yuvipanda commented Nov 17, 2017

@gnestor I guess this is too late to respond, but this is causing problems on mybinder. It would be great if there's a release made with this :)

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Nov 17, 2017

We could do a 5.2.2 and only add this. Sound good?

@yuvipanda

This comment has been minimized.

Copy link
Contributor

yuvipanda commented Nov 17, 2017

@gnestor that would be awesome!

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Nov 21, 2017

Sorry I didn't respond promptly the first time around; not keeping up with my GitHub notifications. It would be handy for binder to have this in a patch release.

@yuvipanda

This comment has been minimized.

Copy link
Contributor

yuvipanda commented Nov 28, 2017

Post-thanksgiving, any luck? :)

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Nov 28, 2017

@yuvipanda So sorry to put this off. Will release 5.2.2 today 👌

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Nov 28, 2017

@meeseeksdev backport to 5.2.2

meeseeksdev bot pushed a commit that referenced this pull request Nov 28, 2017

gnestor added a commit that referenced this pull request Nov 28, 2017

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Nov 28, 2017

Update: notebook 5.2.2 is published to pypi (https://pypi.org/project/notebook/5.2.2/) and PR is submitted for conda-forge (conda-forge/notebook-feedstock#25). Please confirm that this fixes the issue on binder and afterwards I will announce the new version on the mail list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.