Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the prompt_area argument of the output area constructor. #2961

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@jasongrout
Copy link
Member

jasongrout commented Oct 20, 2017

@jasongrout

This comment has been minimized.

Copy link
Member Author

jasongrout commented Oct 20, 2017

CC @gnestor. This fixes a bug in #2681.

jasongrout added a commit to jasongrout/ipywidgets that referenced this pull request Oct 20, 2017

Hide prompt area in classic notebook output widget.
This works around for the bug fixed in jupyter/notebook#2961

Thanks to @mheilman for noting the problem and suggesting a fix.

Fixes jupyter-widgets#1765

@gnestor gnestor merged commit 1405693 into jupyter:master Oct 21, 2017

4 checks passed

codecov/patch Coverage not affected when comparing c888b6a...115bde2
Details
codecov/project 79.01% remains the same compared to c888b6a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor modified the milestones: 5.3, 5.2.1 Oct 21, 2017

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Oct 26, 2017

@meeseeksdev backport to 5.2.1

@meeseeksdev

This comment has been minimized.

Copy link

meeseeksdev bot commented Oct 26, 2017

Oops, something went wrong applying the patch... Please have a look at my logs.

@jupyter jupyter deleted a comment from meeseeksdev bot Oct 27, 2017

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Oct 27, 2017

I manually backported 115bde2 to 5.2.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.