Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the prompt_area argument of the output area constructor. #2961

Merged
merged 1 commit into from Oct 21, 2017

Conversation

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Oct 20, 2017

See #2681 (comment) and jupyter-widgets/ipywidgets#1765

@jasongrout
Copy link
Member Author

@jasongrout jasongrout commented Oct 20, 2017

CC @gnestor. This fixes a bug in #2681.

Loading

jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Oct 20, 2017
This works around for the bug fixed in jupyter/notebook#2961

Thanks to @mheilman for noting the problem and suggesting a fix.

Fixes jupyter-widgets#1765
@gnestor gnestor merged commit 1405693 into jupyter:master Oct 21, 2017
4 checks passed
Loading
@gnestor gnestor added this to the 5.3 milestone Oct 21, 2017
@gnestor gnestor removed this from the 5.3 milestone Oct 26, 2017
@gnestor gnestor added this to the 5.2.1 milestone Oct 26, 2017
@gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 26, 2017

@meeseeksdev backport to 5.2.1

Loading

@meeseeksdev
Copy link

@meeseeksdev meeseeksdev bot commented Oct 26, 2017

Oops, something went wrong applying the patch... Please have a look at my logs.

Loading

@jupyter jupyter deleted a comment from meeseeksdev bot Oct 27, 2017
@gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 27, 2017

I manually backported 115bde2 to 5.2.1 👍

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants