Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more border width to CodeMirror cursor #2983

Merged
merged 3 commits into from Oct 27, 2017

Conversation

@gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 26, 2017

Closes #2909

blink1073
Copy link
Member

blink1073 commented on 0fe8ee1 Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps specify the assumed screen resolution here?

Loading

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Oct 26, 2017

@Carreau We're having a similar Appveyor build issue over here ☹️

Loading

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Oct 27, 2017

@takluyver Care to review and merge?

Loading

@Carreau
Copy link
Member

@Carreau Carreau commented Oct 27, 2017

Clicked on rebuild. I really don't understand how Appveyor works, I can'd find the team section anymore.

Loading

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Oct 27, 2017

Ya me niether...

Loading

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Oct 27, 2017

@Carreau Would you care to review/merge?

Loading

@Carreau
Copy link
Member

@Carreau Carreau commented Oct 27, 2017

Let's try.

Loading

@Carreau Carreau merged commit cd2ac44 into jupyter:master Oct 27, 2017
1 of 2 checks passed
Loading
@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Oct 30, 2017

@meeseeksdev backport to 5.2.1

Loading

@gnestor gnestor deleted the fix-codemirror-cursor branch Oct 30, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants