Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more border width to CodeMirror cursor #2983

Merged
merged 3 commits into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@gnestor
Copy link
Contributor

gnestor commented Oct 26, 2017

Closes #2909

@blink1073

This comment has been minimized.

Copy link
Member

blink1073 commented on notebook/static/notebook/less/codemirror.less in 0fe8ee1 Oct 26, 2017

Perhaps specify the assumed screen resolution here?

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Oct 26, 2017

@Carreau We're having a similar Appveyor build issue over here ☹️

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Oct 27, 2017

@takluyver Care to review and merge?

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Oct 27, 2017

Clicked on rebuild. I really don't understand how Appveyor works, I can'd find the team section anymore.

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Oct 27, 2017

Ya me niether...

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Oct 27, 2017

@Carreau Would you care to review/merge?

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Oct 27, 2017

Let's try.

@Carreau Carreau merged commit cd2ac44 into jupyter:master Oct 27, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Oct 30, 2017

@meeseeksdev backport to 5.2.1

meeseeksdev bot pushed a commit that referenced this pull request Oct 30, 2017

@gnestor gnestor deleted the gnestor:fix-codemirror-cursor branch Oct 30, 2017

gnestor added a commit that referenced this pull request Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.