Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send HTTP shutdown request on 'stop' subcommand #3000

Merged
merged 3 commits into from Nov 2, 2017

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Oct 31, 2017

Signals don't work on Windows. This tries the HTTP shutdown request first. On Unix, it will try SIGTERM after 5 seconds, and SIGKILL after another 5, if the server didn't already exit.

Closes gh-2937

Send HTTP shutdown request on 'stop' subcommand
Signals don't work on Windows. This tries the HTTP shutdown request first.
On Unix, it will try SIGTERM after 5 seconds, and SIGKILL after another 5, if the
server didn't already exit.

Closes gh-2937

@takluyver takluyver added this to the 5.3 milestone Oct 31, 2017

takluyver added some commits Oct 31, 2017

@takluyver takluyver merged commit 15f393b into jupyter:master Nov 2, 2017

4 checks passed

codecov/patch 41.86% of diff hit (target 0%)
Details
codecov/project 78.81% (-0.23%) compared to 4304d5a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:stop-cmd-http branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.