Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send HTTP shutdown request on 'stop' subcommand #3000

Merged
merged 3 commits into from Nov 2, 2017

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Oct 31, 2017

Signals don't work on Windows. This tries the HTTP shutdown request first. On Unix, it will try SIGTERM after 5 seconds, and SIGKILL after another 5, if the server didn't already exit.

Closes gh-2937

Signals don't work on Windows. This tries the HTTP shutdown request first.
On Unix, it will try SIGTERM after 5 seconds, and SIGKILL after another 5, if the
server didn't already exit.

Closes jupytergh-2937
@takluyver takluyver added this to the 5.3 milestone Oct 31, 2017
@takluyver takluyver merged commit 15f393b into jupyter:master Nov 2, 2017
4 checks passed
Loading
@takluyver takluyver deleted the stop-cmd-http branch Nov 2, 2017
@xiaosuyu1997
Copy link

@xiaosuyu1997 xiaosuyu1997 commented Jan 14, 2020

image
Meet a problem when trying to stop jupyter notebook on a server. It seems the httpRequest sent has some permission issue as I'm not root on this server?

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants