Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Folder for document translation #3022

Merged
merged 1 commit into from Nov 20, 2017
Merged

Add Folder for document translation #3022

merged 1 commit into from Nov 20, 2017

Conversation

@ChungJooHo
Copy link
Contributor

@ChungJooHo ChungJooHo commented Nov 6, 2017

As you suggested I first add translation folder. And I added my translation 'Readme.md' in Korean.
Thank you for your suggestion. I will steadily update docs.

I first add my translation 'Readme.md' in Korean
rgbkrk
rgbkrk approved these changes Nov 6, 2017
@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Nov 6, 2017

/cc @willingc

Loading

Copy link
Member

@willingc willingc left a comment

Thanks @ChungJooHo.

Loading

@willingc willingc requested a review from jzf2101 Nov 6, 2017
@willingc
Copy link
Member

@willingc willingc commented Nov 6, 2017

Thanks!

I'll leave for @jzf2101 to review and merge :-)

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 10, 2017

Another options is to use a file name convention like README.ko-KR.md 👍

Loading

@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Nov 10, 2017

Another options is to use a file name convention like README.ko-KR.md

Oh that's true for the base. Then we would just make that folder for the docs/ translations.

Loading

@ChungJooHo
Copy link
Contributor Author

@ChungJooHo ChungJooHo commented Nov 10, 2017

Okay!! Then I will just add folder for translations and rename readme to readme.ko-KR.md :)

Loading

@ChungJooHo
Copy link
Contributor Author

@ChungJooHo ChungJooHo commented Nov 10, 2017

But I think making each language folders like docs/transation/ko-KR is more comfortable to access docs .

Loading

@jzf2101
Copy link
Contributor

@jzf2101 jzf2101 commented Nov 20, 2017

@ChungJooHo this is great thanks!

Loading

@jzf2101 jzf2101 merged commit f34cb00 into jupyter:master Nov 20, 2017
4 checks passed
Loading
@jzf2101 jzf2101 removed their request for review Nov 20, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants