Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Folder for document translation #3022

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
5 participants
@ChungJooHo
Copy link
Contributor

ChungJooHo commented Nov 6, 2017

As you suggested I first add translation folder. And I added my translation 'Readme.md' in Korean.
Thank you for your suggestion. I will steadily update docs.

Add Folder for document translation
I first add my translation 'Readme.md' in Korean
@rgbkrk

rgbkrk approved these changes Nov 6, 2017

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Nov 6, 2017

/cc @willingc

@willingc
Copy link
Member

willingc left a comment

Thanks @ChungJooHo.

@willingc willingc requested a review from jzf2101 Nov 6, 2017

@willingc

This comment has been minimized.

Copy link
Member

willingc commented Nov 6, 2017

Thanks!

I'll leave for @jzf2101 to review and merge :-)

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Nov 10, 2017

Another options is to use a file name convention like README.ko-KR.md 👍

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Nov 10, 2017

Another options is to use a file name convention like README.ko-KR.md

Oh that's true for the base. Then we would just make that folder for the docs/ translations.

@ChungJooHo

This comment has been minimized.

Copy link
Contributor Author

ChungJooHo commented Nov 10, 2017

Okay!! Then I will just add folder for translations and rename readme to readme.ko-KR.md :)

@ChungJooHo

This comment has been minimized.

Copy link
Contributor Author

ChungJooHo commented Nov 10, 2017

But I think making each language folders like docs/transation/ko-KR is more comfortable to access docs .

@jzf2101

This comment has been minimized.

Copy link
Contributor

jzf2101 commented Nov 20, 2017

@ChungJooHo this is great thanks!

@jzf2101 jzf2101 merged commit f34cb00 into jupyter:master Nov 20, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 6894099...4f3b8e0
Details
codecov/project 78.78% remains the same compared to 6894099
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jzf2101 jzf2101 removed their request for review Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.