Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `/files` prefix for PDF-like files #3031

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@gnestor
Copy link
Contributor

gnestor commented Nov 9, 2017

Fixes #2911 (comment)

This adds one more conditional for PDF-like files (currently only PDF) that can be viewed (opened) in the browser but don't work with:

<iframe id="iframe" sandbox="allow-scripts" src="{{file_url}}"></iframe>`

Other file extensions that are like this (off the top of my head) are office files (.doc, .xls, .docx, .xls, .xlsx, .ppt) (at least using Chrome).

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 10, 2017

Makes sense. Let's merge and iterate in master.

@takluyver takluyver merged commit c9a7795 into jupyter:master Nov 10, 2017

4 checks passed

codecov/patch Coverage not affected when comparing bbf0ead...009af0e
Details
codecov/project 78.78% remains the same compared to bbf0ead
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor deleted the gnestor:edit-view-pdf branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.