Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tornado 5: PeriodicCallback loop arg will be removed #3034

Merged
merged 3 commits into from Nov 13, 2017

Conversation

@minrk
Copy link
Member

@minrk minrk commented Nov 10, 2017

PCs are always run with the current eventloop, which is what the loop we have been passing explicitly already is.

Also fixed a case where we were closing ZMQStream and socket separately,
which may have been safe in the past, but can raise errors due to trying to unregister a closed socket with zmq.

minrk added 2 commits Nov 10, 2017
PCs are always run with the current eventloop,
which is what the explicitly passed loop always is for us already
closing stream closes the socket
@minrk minrk added this to the 5.3 milestone Nov 10, 2017
@@ -452,7 +452,6 @@ def on_close(self):
# close the socket directly, don't wait for the stream
Copy link
Member

@takluyver takluyver Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should probably be removed as misleading. And the assignment below is now unnecessary.

Loading

Copy link
Member Author

@minrk minrk Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants