Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include moment locales in package_data #3051

Closed
wants to merge 1 commit into from

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Nov 16, 2017

Closes gh-2953

I'm not quite sure how this interacts with minification, but it appears that in at least some circumstances it expects these files.

@takluyver takluyver added this to the 5.3 milestone Nov 16, 2017
@takluyver takluyver mentioned this pull request Nov 16, 2017
@takluyver
Copy link
Member Author

@takluyver takluyver commented Nov 16, 2017

Ah, actually, I think #3048 is probably a better fix to the same issue.

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented Nov 16, 2017

Closed in favour of #3048.

Loading

@takluyver takluyver closed this Nov 16, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant