Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare non-specific language code when choosing to use Arabic numerals #3055

Merged
merged 1 commit into from Dec 1, 2017

Conversation

@jcb91
Copy link
Contributor

@jcb91 jcb91 commented Nov 17, 2017

As discussed in #3048 (comment),

Currently, country-specific locales like ar-sa (Arabic, Saudi Arabia), end up using the default numerals. This PR alters the comparison to only use the part of the locale before any -.

Otherwise, country-specific locales like `ar-sa` (Arabic, Saudi Arabia), end up using the default numerals
@gnestor
Copy link
Contributor

@gnestor gnestor commented Dec 1, 2017

Thanks @jcb91!

@gnestor gnestor merged commit cbf7db7 into jupyter:master Dec 1, 2017
4 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants