Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare non-specific language code when choosing to use Arabic numerals #3055

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@jcb91
Copy link
Contributor

jcb91 commented Nov 17, 2017

As discussed in #3048 (comment),

Currently, country-specific locales like ar-sa (Arabic, Saudi Arabia), end up using the default numerals. This PR alters the comparison to only use the part of the locale before any -.

Compare non-specific language code for arabic numerals
Otherwise, country-specific locales like `ar-sa` (Arabic, Saudi Arabia), end up using the default numerals
@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Dec 1, 2017

Thanks @jcb91!

@gnestor gnestor merged commit cbf7db7 into jupyter:master Dec 1, 2017

4 checks passed

codecov/patch Coverage not affected when comparing ba33c33...f7ca4a2
Details
codecov/project 78.72% remains the same compared to ba33c33
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.