Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some UI bugs in Firefox #3044 #3058

Merged
merged 3 commits into from Nov 19, 2017

Conversation

Projects
None yet
2 participants
@ffranchina
Copy link
Contributor

ffranchina commented Nov 18, 2017

Here's my PR to solve the reported problems :)

I've cleaned a bit some CSS and I've refined the usability of the "Upload" button": now the clickable area is exactly equal to the button area.
I've tested the changes into Chromium, Firefox (Quantum, too) and Edge and it behaves as expected!

Let me know if you have questions or requests!

Thank you for your work!

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 18, 2017

Thanks - I've just tested this, and it looks good to me.

Oddly, when I move my mouse over it in Chromium, the pointer (hand) cursor appears momentarily, then it goes back to the default (arrow) cursor. In Firefox it uses the hand cursor like the other buttons. I wouldn't hold up the improvements over this, though.

@ffranchina

This comment has been minimized.

Copy link
Contributor Author

ffranchina commented Nov 18, 2017

Yes, I've noticed it: it's due to the fact that Chrome/Chromium doesn't like to have the cursor changed on some kind of object..! Let me see if I can find a clean way to force it :)

@ffranchina

This comment has been minimized.

Copy link
Contributor Author

ffranchina commented Nov 18, 2017

I had to add a browser-specific rule but I think it's worth it since it's very straightforward :)
Now it behaves uniformly.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 19, 2017

Thanks, nice one :-)

@takluyver takluyver merged commit 6f23f45 into jupyter:master Nov 19, 2017

4 checks passed

codecov/patch Coverage not affected when comparing ba33c33...47a6401
Details
codecov/project 78.72% remains the same compared to ba33c33
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.