Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for terminals on Windows #3087

Merged
merged 12 commits into from Dec 1, 2017

Conversation

Projects
None yet
5 participants
@blink1073
Copy link
Member

blink1073 commented Nov 27, 2017

No description provided.

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Nov 27, 2017

Sweet

blink1073 added some commits Nov 27, 2017

if not default_shell and os.name == 'nt':
default_shell = 'cmd.exe'
shell = settings.get('shell_command',
[os.environ.get('SHELL', default_shell)]

This comment has been minimized.

@takluyver

takluyver Nov 27, 2017

Member

I tend to do defaults for environment variables like os.environ.get('SHELL') or default_shell, because setting an environment variable to the empty string is equivalent by convention to unsetting it.

@blink1073 blink1073 changed the title Add support for terminals on Windows [WIP] Add support for terminals on Windows Nov 27, 2017

@blink1073

This comment has been minimized.

Copy link
Member Author

blink1073 commented Nov 27, 2017

I'm going to hold off on this pending support for Python 2.7 on Windows. cf spyder-ide/pywinpty#75

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 28, 2017

Up to you, but I'm happy for it to be a Python-3-only feature. Next year we might be looking at doing Notebook 6.0 and requiring Python 3, in any case.

@blink1073

This comment has been minimized.

Copy link
Member Author

blink1073 commented Nov 28, 2017

Already mostly done: cf jupyter/terminado#50

blink1073 added some commits Nov 28, 2017

@blink1073 blink1073 changed the title [WIP] Add support for terminals on Windows Add support for terminals on Windows Nov 28, 2017

@blink1073

This comment has been minimized.

Copy link
Member Author

blink1073 commented Nov 28, 2017

Good to go

@blink1073

This comment has been minimized.

Copy link
Member Author

blink1073 commented Nov 28, 2017

Updated to use powershell on Windows if sh is not available, which is what VS Code uses.

@gnestor gnestor added this to the 5.3 milestone Dec 1, 2017

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Dec 1, 2017

Thanks @blink1073!

@gnestor gnestor merged commit 7b8759f into jupyter:master Dec 1, 2017

4 checks passed

codecov/patch 62.5% of diff hit (target 0%)
Details
codecov/project 78.58% (+<.01%) compared to ee419c0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stonebig

This comment has been minimized.

Copy link

stonebig commented Dec 9, 2017

hi, I think I'm hitting this with Jupyterlab-0.30.5 / terminado-0.8.1 / Pywinpty-0.5.1... Could you do a release soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.