Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use `requirejs` vs. `require` #3097

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
4 participants
@gnestor
Copy link
Contributor

gnestor commented Nov 30, 2017

Closes #155

@gnestor gnestor force-pushed the gnestor:requirejs branch from 4767340 to 4d258a8 Nov 30, 2017

@jasongrout

This comment has been minimized.

Copy link
Member

jasongrout commented Nov 30, 2017

Closes jupyterlab/jupyterlab#3281

Wrong issue?

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Dec 1, 2017

Yep, thanks @jasongrout 👌

@gnestor gnestor changed the title Use `requirejs` vs. `require` [WIP] Use `requirejs` vs. `require` Dec 1, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 14, 2017

@gnestor is this still a WIP, or do you think it's ready to merge?

@gnestor

This comment has been minimized.

Copy link
Contributor Author

gnestor commented Dec 14, 2017

@Carreau @rgbkrk Care to review before we merge?

Here is the merged PR on ipython-contrib: ipython-contrib/jupyter_contrib_nbextensions#1165

@rgbkrk

rgbkrk approved these changes Dec 14, 2017

Copy link
Member

rgbkrk left a comment

It's looking good to me, I can't see what might be missed so I think this is fit to ship.

@takluyver takluyver added this to the 5.3 milestone Dec 14, 2017

@takluyver takluyver merged commit ca50f1a into jupyter:master Dec 14, 2017

4 checks passed

codecov/patch Coverage not affected when comparing ee419c0...4d258a8
Details
codecov/project 78.57% remains the same compared to ee419c0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 14, 2017

Thanks @rgbkrk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.