Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use requirejs vs. require #3097

Merged
merged 1 commit into from Dec 14, 2017
Merged

[WIP] Use requirejs vs. require #3097

merged 1 commit into from Dec 14, 2017

Conversation

@gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 30, 2017

Closes #155

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Nov 30, 2017

Closes jupyterlab/jupyterlab#3281

Wrong issue?

Loading

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Dec 1, 2017

Yep, thanks @jasongrout 👌

Loading

@gnestor gnestor changed the title Use requirejs vs. require [WIP] Use requirejs vs. require Dec 1, 2017
@takluyver
Copy link
Member

@takluyver takluyver commented Dec 14, 2017

@gnestor is this still a WIP, or do you think it's ready to merge?

Loading

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Dec 14, 2017

@Carreau @rgbkrk Care to review before we merge?

Here is the merged PR on ipython-contrib: ipython-contrib/jupyter_contrib_nbextensions#1165

Loading

rgbkrk
rgbkrk approved these changes Dec 14, 2017
Copy link
Member

@rgbkrk rgbkrk left a comment

It's looking good to me, I can't see what might be missed so I think this is fit to ship.

Loading

@takluyver takluyver added this to the 5.3 milestone Dec 14, 2017
@takluyver takluyver merged commit ca50f1a into jupyter:master Dec 14, 2017
4 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented Dec 14, 2017

Thanks @rgbkrk

Loading

@rgbkrk rgbkrk deleted the requirejs branch Dec 15, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants