Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding option to specify extra services #3158

Merged
merged 1 commit into from Jan 8, 2018
Merged

Conversation

@shiti-saxena
Copy link
Contributor

@shiti-saxena shiti-saxena commented Dec 21, 2017

the user specified extra services will be loaded before the default handlers (simplify kernel gateway integration)

@shiti-saxena
Copy link
Contributor Author

@shiti-saxena shiti-saxena commented Dec 21, 2017

Created based on the feedback for #3006

Loading

…he default handlers (simplify kernel gateway integration)
@takluyver
Copy link
Member

@takluyver takluyver commented Jan 5, 2018

Loading

minrk
minrk approved these changes Jan 5, 2018
@takluyver
Copy link
Member

@takluyver takluyver commented Jan 8, 2018

@gnestor is about to release 5.3. Do we slip this in, or leave it for 5.4?

Loading

@gnestor
Copy link
Contributor

@gnestor gnestor commented Jan 8, 2018

This looks harmless to me, so I say let's ship it 👍

@takluyver Feel free to merge.

Loading

@gnestor gnestor added this to the 5.3 milestone Jan 8, 2018
@takluyver takluyver merged commit 27c00bf into jupyter:master Jan 8, 2018
4 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented Jan 8, 2018

Thanks :-)

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants