Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding option to specify extra services #3158

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
4 participants
@shiti-saxena
Copy link
Contributor

shiti-saxena commented Dec 21, 2017

the user specified extra services will be loaded before the default handlers (simplify kernel gateway integration)

@shiti-saxena

This comment has been minimized.

Copy link
Contributor Author

shiti-saxena commented Dec 21, 2017

Created based on the feedback for #3006

adding option to specify extra services which will be loaded before t…
…he default handlers (simplify kernel gateway integration)

@shiti-saxena shiti-saxena force-pushed the shiti-saxena:dev branch from 7062fb1 to 37bb6e6 Dec 21, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 5, 2018

@minrk

minrk approved these changes Jan 5, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 8, 2018

@gnestor is about to release 5.3. Do we slip this in, or leave it for 5.4?

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Jan 8, 2018

This looks harmless to me, so I say let's ship it 👍

@takluyver Feel free to merge.

@gnestor gnestor added this to the 5.3 milestone Jan 8, 2018

@takluyver takluyver merged commit 27c00bf into jupyter:master Jan 8, 2018

4 checks passed

codecov/patch 95.23% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +16.75% compared to 782e9ce
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 8, 2018

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.