Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn_bad_name should not use global name #3160

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@Sukneet
Copy link
Contributor

Sukneet commented Dec 21, 2017

warn_bad_name in get_name should use the local variable name_or_data not name

warn_bad_name should not use global name
warn_bad_name in get_name should use the local variable name_or_data not name

@takluyver takluyver added this to the 5.3 milestone Dec 22, 2017

@takluyver takluyver merged commit 3857c92 into jupyter:master Dec 22, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 782e9ce...ca5e39a
Details
codecov/project 78.48% remains the same compared to 782e9ce
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 22, 2017

Thanks, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.