Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment issue [FIXED] #3173

Merged
merged 1 commit into from Jun 3, 2020
Merged

Conversation

Axle7XStriker
Copy link
Contributor

To fix the alignment issue which was found out to occur in most of the browsers including Chrome and Firefox because of the scroll bar becoming visible and invisible whichever is required.

The main problem this was being caused was because of 'margin-left' property being set to 'auto' as well as the 'overflow' property being set to 'auto'.

So, to fix this issue I updated the 'margin-left' property to align it with the header of the page whenever changes like page reload, resize, etc occurs.

closes #3109

@Axle7XStriker
Copy link
Contributor Author

I am not able to figure out why the Travis CI build failed. Can anyone please tell me the reason behind it.

@takluyver
Copy link
Member

Probably a random failure. I've restarted the job that failed.

I'm not that keen on javascript to fix CSS layout issues. Is it possible to do something with CSS calc() instead?

@Axle7XStriker
Copy link
Contributor Author

I don't think we can get the same flexibility with CSS calc() as we get from using the 'auto' value in margin.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the JS solution is warranted here, thanks!

@Zsailer
Copy link
Member

Zsailer commented Aug 19, 2020

I think we need to revert this change. It's causing new alignment issues discovered in #5687 that are slightly worse than before.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

out of alignment in chrome
4 participants