Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force padding top bottom to 1px for div.output_area pre #3194

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@Naereen
Copy link
Contributor

Naereen commented Jan 9, 2018

See #3193

@gnestor gnestor added this to the 5.3 milestone Jan 9, 2018

@gnestor gnestor merged commit de92a2b into jupyter:master Jan 9, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 91d46c5...4a6a15a
Details
codecov/project 78.73% remains the same compared to 91d46c5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Naereen

This comment has been minimized.

Copy link
Contributor Author

Naereen commented Jan 19, 2018

(I am simply curious)
@gnestor how does the "Credits" list of people who contributed is generated for blog posts like this one ?

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 19, 2018

Sorry, you should have been in that list. I think it was copied from the changelog in the docs. You are listed in that version, but I added you just before the final release; I guess the blog post was written as a draft before that, and published without being updated.

As for how it's generated, @gnestor can probably give you more detail, but I expect it's based on git log and some amount of manual cleanup.

@Naereen

This comment has been minimized.

Copy link
Contributor Author

Naereen commented Jan 19, 2018

@takluyver no I honestly don't care, I was simply curious of the ratio between automated and manual tasks in this step 😃

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 19, 2018

I'm now interested to know that as well. Min's ghpro tool can get a list of authors automatically from Git and Github, but I don't think it adds the Github usernames automatically.

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Jan 19, 2018

There's a notebook for that!

https://gist.github.com/gnestor/ae2449547e35dc779f36dfb322ca6ca0

I query Github for all PRs marked with a milestone (e.g. "5.3") and format them in a markdown and RST list for easy copying into our docs/source/changelog.rst file, Github release description, Google Group announcement, and Medium blog post. I then get a unique list of contributors by picking the user field from each PR. @Naereen I'm sorry, it looks like this method left you out ☹️ I assume the user associated with a PR is the author, but maybe it's the user who merged the PR? Maybe that's the source of error? @takluyver Do you see any obvious error in this notebook?

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 19, 2018

I think you just updated the changelog before this PR was merged. I edited it manually just before doing the release to add the last few PRs that were merged.

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Jan 19, 2018

Oh I see.... I just re-ran the notebook and now I see @Naereen 👍

@Naereen

This comment has been minimized.

Copy link
Contributor Author

Naereen commented Jan 20, 2018

Great 👍 i'll read the notebook with attention :-) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.