Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit length of GUI autocomplete to 1000 #3195

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
2 participants
@areading314
Copy link

areading314 commented Jan 9, 2018

If an object's dir() call returns a long list (greater than a few thousand), the UI locks up while it is creating this long list of elements. This just limits the maximum length to 1000 elements.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 10, 2018

Thanks. We also introduced a limit in IPython - see ipython/ipython#10743 - but I think the new Jedi completions might not be affected by that.

@takluyver takluyver added this to the 5.4 milestone Jan 10, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 10, 2018

I've marked this as for 5.4, as we're just about to release notebook 5.3.

@areading314

This comment has been minimized.

Copy link
Author

areading314 commented Jan 18, 2018

@takluyver is there anything else I need to do to get this merged?

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 19, 2018

No, I think this makes sense as is. Thanks!

@takluyver takluyver merged commit 31215b8 into jupyter:master Jan 19, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 91d46c5...426346f
Details
codecov/project 78.73% remains the same compared to 91d46c5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.