Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use setuptools in setup.py #3206

Merged
merged 2 commits into from Jan 15, 2018

Conversation

Projects
None yet
3 participants
@takluyver
Copy link
Member

takluyver commented Jan 12, 2018

This copies what we've already done for some other packages: always use setuptools but disable its implicit egg building which causes so many headaches. The setup code can be significantly simpler if it's not trying to handle the case where setuptools isn't in use.

takluyver added some commits Jan 12, 2018

Always use setuptools in setup.py
This copies what we've already done for some other packages: always use setuptools
but disable its implicit egg building which causes so many headaches. The setup code
can be significantly simpler if it's not trying to handle the case where setuptools
isn't in use.

@minrk minrk merged commit b439a9f into jupyter:master Jan 15, 2018

4 checks passed

codecov/patch Coverage not affected when comparing de92a2b...3a0bb61
Details
codecov/project 78.73% remains the same compared to de92a2b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver added this to the 5.3 milestone Jan 17, 2018

@takluyver takluyver deleted the takluyver:use-setuptools branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.