Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace symlinked favicon with a copy #3220

Merged
merged 1 commit into from Jan 16, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Jan 16, 2018

This is the simplest way to fix it for now. I may need to do a quick 5.3.1 release.

Closes gh-3215

@takluyver takluyver merged commit bbce09a into jupyter:master Jan 16, 2018
4 checks passed
Loading
@takluyver takluyver deleted the favicon-not-symlink branch Jan 16, 2018
@Carreau
Copy link
Member

@Carreau Carreau commented Jan 16, 2018

Thanks for the quickfix ,

may I suggest a unit-test in travis that fail if we introduce symlink in the repo ?

Loading

@takluyver takluyver added this to the 5.3 milestone Jan 17, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Jan 17, 2018

You may, but I might suggest a PR ;-)

Hope you're getting over your jet lag OK.

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants