Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace symlinked favicon with a copy #3220

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Jan 16, 2018

This is the simplest way to fix it for now. I may need to do a quick 5.3.1 release.

Closes gh-3215

@takluyver takluyver merged commit bbce09a into jupyter:master Jan 16, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 4179d60...3b069e3
Details
codecov/project 78.76% remains the same compared to 4179d60
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:favicon-not-symlink branch Jan 16, 2018

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Jan 16, 2018

Thanks for the quickfix ,

may I suggest a unit-test in travis that fail if we introduce symlink in the repo ?

@takluyver takluyver added this to the 5.3 milestone Jan 17, 2018

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Jan 17, 2018

You may, but I might suggest a PR ;-)

Hope you're getting over your jet lag OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.