Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No symlink #3227

Merged
merged 1 commit into from Jan 17, 2018
Merged

No symlink #3227

merged 1 commit into from Jan 17, 2018

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Jan 17, 2018

Make sure the test fails if the repo contains symlinks (this PR contains a symlink to make sure the test works as expected, I'll force push once the test fails).

rgbkrk
rgbkrk approved these changes Jan 17, 2018
@takluyver
Copy link
Member

@takluyver takluyver commented Jan 17, 2018

Travis tests have failed as planned.

Loading

@Carreau
Copy link
Member Author

@Carreau Carreau commented Jan 17, 2018

All fixed !

Loading

@Carreau Carreau added this to the 5.4 milestone Jan 17, 2018
@takluyver takluyver merged commit 6526a19 into jupyter:master Jan 17, 2018
4 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented Jan 17, 2018

Thanks :-)

Loading

@Carreau Carreau deleted the nsymlink branch Aug 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants