Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No symlink #3227

Merged
merged 1 commit into from Jan 17, 2018

Conversation

Projects
None yet
3 participants
@Carreau
Copy link
Contributor

Carreau commented Jan 17, 2018

Make sure the test fails if the repo contains symlinks (this PR contains a symlink to make sure the test works as expected, I'll force push once the test fails).

@rgbkrk

rgbkrk approved these changes Jan 17, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 17, 2018

Travis tests have failed as planned.

@Carreau Carreau force-pushed the Carreau:nsymlink branch from 9f729bc to 3275f77 Jan 17, 2018

@Carreau

This comment has been minimized.

Copy link
Contributor Author

Carreau commented Jan 17, 2018

All fixed !

@Carreau Carreau added this to the 5.4 milestone Jan 17, 2018

@takluyver takluyver merged commit 6526a19 into jupyter:master Jan 17, 2018

4 checks passed

codecov/patch Coverage not affected when comparing fe2502d...3275f77
Details
codecov/project 78.76% remains the same compared to fe2502d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 17, 2018

Thanks :-)

@Carreau Carreau deleted the Carreau:nsymlink branch Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.